Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] com.crunchyroll.stream.app.yml #104

Merged
merged 4 commits into from
Jun 11, 2024
Merged

Conversation

ediaz23
Copy link
Contributor

@ediaz23 ediaz23 commented May 19, 2024

No description provided.

Copy link

github-actions bot commented May 29, 2024

Check Results for com.crunchyroll.stream.app.yml:

Package Metadata

✅ Check passed.

Compatibility Check

App com.crunchyroll.stream.app

Skip because this component is not native

All OK

Service com.crunchyroll.stream.app.service

Skip because this component is not native

All OK

@mariotaku
Copy link
Member

Thank you for the submission!

Could you take some screenshots and add them to the descriptions if possible?

@ediaz23
Copy link
Contributor Author

ediaz23 commented May 30, 2024

Hello, yes, but there are already screenshots in the description, are they not working?

Thanks.

@mariotaku
Copy link
Member

There are few issues:

  1. Screenshots are not for 16:9 screen (and with Chrome address bars)
  2. To make sure there's no dead link in case you pushed changes to move the images, you could use a commit ID instead of main branch to get the link of the image.

@ediaz23
Copy link
Contributor Author

ediaz23 commented May 30, 2024

Updated, open to any comments.

@mariotaku mariotaku merged commit 23f14a4 into webosbrew:main Jun 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants