Add ruff

[pickfire]

Fix #603

[pickfire]

The test failures seemed unrelated.

[fvalverd]

@pickfire is it possible that the expected values in the ruff + fix are wrong?

I ran the tests on my machine for ruff and without the following change the tests were failing:

function getFixParams(dir) {
	return {
		// Expected output of the linting function
		cmdOutput: {
			status: 0,
			stdout: "",
		},
		// Expected output of the parsing function
		lintResult: {
			isSuccess: true,
			warning: [],
			error: [],
		},
	};
}

the thing is the option --fix-only at

lint-action/src/linters/ruff.js

Lines 52 to 53 in 5981801

	const fixArg = fix ? "--fix-only" : "";
	return run(`${prefix} ruff check --quiet ${fixArg} ${args} .`, {

ruff doesn't report the violations:

--fix-only
          Fix any fixable lint violations, but don't report on leftover violations.

Here is my context:

$  uname -s -r -p -o 
Linux 5.19.0-41-generic x86_64 GNU/Linux

$ node --version
v16.20.0

$ jest --version
29.3.1

$ python --version
Python 3.10.11

$ pip freeze | grep ruff
ruff==0.0.267

[charliermarsh]

Haven't looked at this PR closely, but FYI we recently changed --fix-only to always return a code of 0, unless you provide --exit-non-zero-on-fix, in which case, it'll exit 1 if it fixes any violations.

Relevant link to the breaking change list: https://github.com/charliermarsh/ruff/blob/main/BREAKING_CHANGES.md#--fix-only-now-exits-with-a-zero-exit-code-unless---exit-non-zero-on-fix-is-specified-4146

[pickfire]

I don't get why is black linter failing in the tests.

[fvalverd]

I don't get why is black linter failing in the tests.

mypy and black latest version are failing because the output format changed, I provided you a PR with the necessary changes to make them pass in here https://github.com/pickfire/lint-action/pull/1/files

[tylerlaprade]

@fvalverd, tests still seem to be failing

[fvalverd]

There are 3 failures:

• macos: that is swift, nothing to do with this PR or Python in general
• ubuntu: that is also swift, it has nothing to do with this PR or Python in general
• windows: those are related to ruff and black, probably the syntax of the output is the problem, but I don't have access to that OS to corroborate the problem

[luzfcb]

I don't know if it makes anything easier, but ruff currently supports some output formats, such as github and json

https://docs.astral.sh/ruff/settings/#output-format

$ ruff check --output-format github .
::error title=Ruff (C408),file=/home/luzfcb/projects/labcodes/pythondotorg/events/tests/test_utils.py,line=36,col=17,endLine=36,endColumn=60::events/tests/test_utils.py:36:17: C408 Unnecessary `dict` call (rewrite as a literal)

$ ruff check --output-format json .
[
  {
    "cell": null,
    "code": "C408",
    "end_location": {
      "column": 60,
      "row": 36
    },
    "filename": "/home/luzfcb/projects/labcodes/pythondotorg/events/tests/test_utils.py",
    "fix": null,
    "location": {
      "column": 17,
      "row": 36
    },
    "message": "Unnecessary `dict` call (rewrite as a literal)",
    "noqa_row": 36,
    "url": "https://docs.astral.sh/ruff/rules/unnecessary-collection-call"
  }
]

[BroFromSpace]

Any progress on this PR?

[pickfire]

@BroFromSpace I no longer need this, I guess you can continue working on it. Will close this.