-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: tidy verbose telemetry service name #45
Conversation
08bc2fc
to
e63555f
Compare
Thanks for the PR, these are solid improvements! I just added a couple of comments in terms of adjusting the keys that we use for these to better align the semantics with the values. @lxfontes may have further thoughts to add, I'll happily approve from my end once you have a chance the address the feedback. |
Signed-off-by: jamesstocktonj1 <[email protected]>
Signed-off-by: jamesstocktonj1 <[email protected]>
13e7825
to
a25710b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good on my part!
I'm leaving this open pending any feedback from @lxfontes, otherwise it looks good to merge on my end. Lucas, feel free to merge this if you don't have anything to add. I’ll check back tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM to me as well, @lxfontes feel free to merge when approved!
Feature or Problem
Tidy up the open telemetry attributes:
service.name
host.id
container.id
container.image.name
Related Issues
Release Information
Consumer Impact
Testing
Tested using some simple modifications to the http-server example which can be found in this Gist. The tracer collecter is Jaeger.
Before
After