Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tidy verbose telemetry service name #45

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

jamesstocktonj1
Copy link
Contributor

Feature or Problem

Tidy up the open telemetry attributes:

  • Replace provider executable name in favour of the Provider Key for service.name
    • Provider Key is unique to each provider instance whereas the executable name is not
  • Add Host ID to host.id
  • Add Instance ID to container.id
  • Move provider binary name to container.image.name

Related Issues

Release Information

Consumer Impact

Testing

Tested using some simple modifications to the http-server example which can be found in this Gist. The tracer collecter is Jaeger.

Before

Screenshot from 2024-10-05 14-06-20

After

Screenshot from 2024-10-05 14-06-44

@jamesstocktonj1 jamesstocktonj1 requested a review from a team as a code owner October 5, 2024 15:23
@lxfontes lxfontes self-assigned this Oct 6, 2024
observability.go Outdated Show resolved Hide resolved
observability.go Outdated Show resolved Hide resolved
@joonas
Copy link
Member

joonas commented Oct 6, 2024

Thanks for the PR, these are solid improvements!

I just added a couple of comments in terms of adjusting the keys that we use for these to better align the semantics with the values.

@lxfontes may have further thoughts to add, I'll happily approve from my end once you have a chance the address the feedback.

Copy link
Member

@joonas joonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on my part!

@joonas
Copy link
Member

joonas commented Oct 6, 2024

I'm leaving this open pending any feedback from @lxfontes, otherwise it looks good to merge on my end.

Lucas, feel free to merge this if you don't have anything to add. I’ll check back tomorrow.

Copy link
Member

@brooksmtownsend brooksmtownsend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to me as well, @lxfontes feel free to merge when approved!

@lxfontes lxfontes merged commit 035a918 into wasmCloud:main Oct 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants