properly handle biri.Error #163
Open
+50
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregfurman
reviewed
Nov 14, 2024
There was a problem hiding this comment.
Hey! Thanks for the contribution and quick fix for this. Any chance you have capacity to add an integration test to the opensearch suite for this case?
There are 2 deletion tests but none test this case you've encountered of trying to delete a non-existent document AFAIK. See opensearch/integration_test.go.
|
@gregfurman, I've added an integration test for this case. Please take a look |
gregfurman
reviewed
Nov 14, 2024
Comment on lines
479
to
480
| var respCode int | ||
| respCode = get.StatusCode |
There was a problem hiding this comment.
Linter doesn't like this one.
Suggested change
| var respCode int | |
| respCode = get.StatusCode | |
| respCode := get.StatusCode |
|
Awesome! Thanks for adding that test. Your golangci-lint step is failing so just run I added a suggestion that you can also accept that should fix it. |
|
@gregfurman , fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #162