Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allow one to pass a single message or a list of messages to the
fail
andsuccess
methods.This will allow the Device gem to pass those messages to warden, and get them displayed on the login pages.
Our use case is the following : We are adding a "delayable" strategy which adds exponential delay between login failures with an information message, and when a single login try remain, we want to show the alert telling about the delay before the user will be able to retry to login, and the alert that only one try remain before his account is being locked.
This PR also adds an
Earthlyfile
and adocker-compose.yml
file for convinience to run Rspec with Docker and Earthly with a single command:I can even update your Github workflow in order to use Earthly so that we truly benefit from a complete isolation avoiding to get tests failing on the CI, but not locally since Earthly runs Docker in Docker to the tests.