Increase contrast for .status_prompt style #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
needed to reach WCAG-enough contrast over white background
✅ Deploy Preview for w3c-typography ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Would you please provide a before and after screenshot for our reference, @dontcallmedom? |
|
(changing WCAG contrast ratio from 2.32 to 4.71 according to WebAIM contrast checkr) |
|
@xfq i had already done some tests for this suggested change, and i think it will probably be ok, even though it doesn't de-emphasise the affected text as much as i'd have liked. I'm assuming that Dom has picked the lightest grey colour that passes WAI AA - i didn't check that. |
|
Thanks, @dontcallmedom and @r12a! |
xfq
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needed to reach WCAG-enough contrast over white background