-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates the definition of graph isomorphism #140
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I notice that M was also applied to the predicate of (asserted) triples and triple terms, whereas the original definition kept p as is. Since p is always an IRI, this is absolutely equivalent, but more verbose...
I have a slight preference for the terse version (p instead of M(p)), but I can live with both.
I'm fine with changing it back to p if others prefer that as well. However, in this case, I would also change the M(p) in the new fourth bullet point to p. Just to be consistent. |
I prefer Also, it looks clearer to me because it is mapping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Given the approvals of all other editors, and also of @pfps who created the issue that this PR addresses, I will merge the PR now. |
.. as proposed in #128, including the additional change proposed in #128 (comment)
Notice that I also removed the "that is a node of G" part of bullet point 2 and 3. This change is needed for the new recursive part of the definition to be correct (i.e., when applying M to IRIs or literals inside triple terms).
Additionally, I also changed the last (now fifth) bullet point by putting M(p) in the second triple mentioned in this bullet point. While this change is not strictly necessary (because p is an IRI and M maps each IRI to itself), using M here looks a bit more consistent.
Preview | Diff