Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore a subsection of privacy considerations #71

Merged
merged 4 commits into from
Feb 20, 2025

Conversation

andyleiserson
Copy link
Collaborator

@andyleiserson andyleiserson commented Jan 23, 2025

This text was removed when replacing the ad identifier with filter data. Since I think the consideration remains more or less the same, this change restores the text, modifying it to refer to filter data.


Preview | Diff

This text was removed when replacing the ad identifier with filter data.
Since I think the consideration remains more or less the same,
this change restores the text, modifying it to refer to filter data.
@csharrison
Copy link
Collaborator

All of the considerations equally apply to putting identifiers in histogramIndex right? Maybe we can combine them here.

Copy link
Member

@martinthomson martinthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Agreeing with Charlie,) I think that this could be made broader than just filterData (whatever we end up renaming it to).

andyleiserson and others added 2 commits February 20, 2025 13:41
Co-authored-by: Andrew Paseltiner <[email protected]>
@martinthomson martinthomson merged commit 75d1650 into main Feb 20, 2025
1 check passed
@andyleiserson andyleiserson deleted the filter-data-tracking branch February 20, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants