feat[venom]: improve liveness computation #4301
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traversing in reverse topsort order improves stack scheduling slightly (codesize improvement of about 0.35%) this commit also adds a topsort method to CFGAnalysis, and speeds it up by only checking the terminator instruction instead of iterating over all the instructions in every basic block.
|
marking as draft since this seems to introduce a scheduler regression elsewhere 😱 |
it is redundant with CFGAnalysis cfg_out
this shaves 1.5% off bytecode size
shared code between remove_unreachable_blocks and sccp
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -1,8 +1,7 @@ | |||
| from typing import Iterator, Optional | |||
|
|
|||
| from vyper.codegen.ir_node import IRnode | |||
| from vyper.utils import OrderedSet | |||
| from vyper.venom.basicblock import CFG_ALTERING_INSTRUCTIONS, IRBasicBlock, IRLabel, IRVariable | |||
| from vyper.venom.basicblock import IRBasicBlock, IRLabel, IRVariable | |||
Check failure
Code scanning / CodeQL
Module-level cyclic import Error
| @@ -1,8 +1,7 @@ | |||
| from typing import Iterator, Optional | |||
|
|
|||
| from vyper.codegen.ir_node import IRnode | |||
| from vyper.utils import OrderedSet | |||
| from vyper.venom.basicblock import CFG_ALTERING_INSTRUCTIONS, IRBasicBlock, IRLabel, IRVariable | |||
| from vyper.venom.basicblock import IRBasicBlock, IRLabel, IRVariable | |||
Check failure
Code scanning / CodeQL
Module-level cyclic import Error
| @@ -1,8 +1,7 @@ | |||
| from typing import Iterator, Optional | |||
|
|
|||
| from vyper.codegen.ir_node import IRnode | |||
| from vyper.utils import OrderedSet | |||
| from vyper.venom.basicblock import CFG_ALTERING_INSTRUCTIONS, IRBasicBlock, IRLabel, IRVariable | |||
| from vyper.venom.basicblock import IRBasicBlock, IRLabel, IRVariable | |||
Check failure
Code scanning / CodeQL
Module-level cyclic import Error
|
superseded by #4330 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
traversing in reverse topsort order improves stack scheduling slightly (codesize improvement of about 0.35%)
this commit also adds a topsort method to CFGAnalysis, and speeds it up by only checking the terminator instruction instead of iterating over all the instructions in every basic block.
What I did
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture