Browse filter results on page #473
Conversation
There was a problem hiding this comment.
@litvinovg I don't have any big complain on your code, the implementation is aligned with other Vitro DataGetters implementations. Please find a couple of my tiny comments.
The PR feature has been tested and it works as it is described with the exception of person's publications.
api/src/main/java/edu/cornell/mannlib/vitro/webapp/search/controller/PagedSearchController.java
Outdated
Show resolved
Hide resolved
api/src/main/java/edu/cornell/mannlib/vitro/webapp/search/controller/PagedSearchController.java
Outdated
Show resolved
Hide resolved
api/src/main/java/edu/cornell/mannlib/vitro/webapp/search/controller/PagedSearchController.java
Outdated
Show resolved
Hide resolved
.../vitro/webapp/edit/n3editing/configuration/preprocessors/utils/ProcessDataGetterN3Utils.java
Outdated
Show resolved
Hide resolved
...ain/java/edu/cornell/mannlib/vitro/webapp/utils/dataGetter/SearchFilterValuesDataGetter.java
Outdated
Show resolved
Hide resolved
| uil-data:browse_results_alphabetical_index.Vitro | ||
| rdf:type owl:NamedIndividual ; | ||
| rdf:type uil:UILabel ; | ||
| rdfs:label "a,b,c,d,e,f,g,h,i,j,k,l,m,n,o,p,q,r,s,t,u,v,w,x,y,z"@de-DE ; |
There was a problem hiding this comment.
should be extended with German letters. This might be a task for a native German speaker, but it looks to me this might be ä, ö, ü, ß at the end after z - link
There was a problem hiding this comment.
DIN 5007 should be applied for sorting- https://de.wikipedia.org/wiki/Alphabetische_Sortierung#Deutschland
Additional letter for Umlauts in the browsing list are not necessary.
| uil-data:browse_results_alphabetical_index.Vitro | ||
| rdf:type owl:NamedIndividual ; | ||
| rdf:type uil:UILabel ; | ||
| rdfs:label "a,b,c,d,e,f,g,h,i,j,k,l,m,n,o,p,q,r,s,t,u,v,w,x,y,z"@pt-BR ; |
There was a problem hiding this comment.
Should check this with a Portuguese native speaker
…r in SearchFilterValuesDataGetter
litvinovg
force-pushed
the
browse-filter-results-page-option
branch
from
0e97588
to
af7a82e
Compare
VIVO PR
What does this pull request do?
Adds an option to select search filter to display filtered results on custom page.
What's new?
Refactored PagedSearchController.
Added search filter option to ManagePageGenerator
Refactored ProcessN3GetterDataMap
Created new data getter class display:SearchFilterValuesDataGetter , java implementation in SearchFilterValuesDataGetter.java
Created boolean data property search:reverseFacetOrder to reverse sort order of facets.
Created filters to filter result in alphabetical indexes
:filter_label_regex - default regex filter that uses i18n field :field_label_display with name locale + _label_display
:filter_raw_label_regex - fallback regex filter that uses nameRaw search field for VIVO instances without i18n support
How should this be tested?
A description of what steps someone could take to:
Additional Notes:
This change require documentation to be updated.
Interested parties
@hauschke @VIVO-project/vivo-committers
Reviewers' expertise
Candidates for reviewing this PR should have some of the following expertises:
Reviewers' report template
Please update the following template which should be used by reviewers.
General comment
A reviewer should provide here comments and suggestions for requested changes if any.
Testing
A reviewer should briefly describe here how it was tested
Code reviewing
A reviewer should briefly describe here which part was code reviewed