feat: Add downloadUrl for derives #1290
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArneGudermann
added
feature
phorward
requested changes
Oct 21, 2024
Co-authored-by: Jan Max Meyer <[email protected]>
Co-authored-by: Jan Max Meyer <[email protected]>
Co-authored-by: Jan Max Meyer <[email protected]>
Co-authored-by: Jan Max Meyer <[email protected]>
sveneberth
requested changes
Oct 23, 2024
| and "dlkey" in skel | ||
| and "name" in skel | ||
| ): | ||
| res["downloadUrl"] = file.create_download_url( |
There was a problem hiding this comment.
This is the opposite of #1252, I would keep it as it is.
Co-authored-by: Sven Eberth <[email protected]>
|
Currently replaced by #1305 due heavy runtime impact. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #506