Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File-module reference should use instance #1252

Open
phorward opened this issue Sep 2, 2024 · 0 comments · May be fixed by #1293
Open

File-module reference should use instance #1252

phorward opened this issue Sep 2, 2024 · 0 comments · May be fixed by #1293
Assignees
@bb-mausbrand
Labels
help wanted Extra attention is needed Priority: Medium This issue may be useful, and needs some attention. refactoring Pull requests that refactor code but do not change its behavior.

Comments

@phorward
Copy link
Member

phorward commented Sep 2, 2024

Please use self instead of the class to allow subclassing.

       bucket = self.get_bucket(dl_key)

(Please change all File.$any to self.$any)

And I would change external File.$any to conf.main_app.file.$any

Originally posted by @sveneberth in #1241 (comment)
@phorward phorward added help wanted Extra attention is needed Priority: Medium This issue may be useful, and needs some attention. refactoring Pull requests that refactor code but do not change its behavior. labels Sep 2, 2024
@phorward phorward mentioned this issue Sep 2, 2024
Merged
@sveneberth sveneberth linked a pull request Oct 22, 2024 that will close this issue
refactor: File-module reference should use instance #1293
Open
@sveneberth sveneberth mentioned this issue Oct 23, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bb-mausbrand bb-mausbrand

Labels
help wanted Extra attention is needed Priority: Medium This issue may be useful, and needs some attention. refactoring Pull requests that refactor code but do not change its behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: File-module reference should use instance bb-mausbrand/viur-core
2 participants
@phorward @bb-mausbrand