feat!: update to chokidar v4

[bluwy]

Description

close #18129

NOTE: I started trying to bundle the chokidar types instead of inlining it, but it didn't work out as easily because chokidar's types includes a lot of internal stuff, which causes bundling issues, type compat issues, and large bundle size. At the end it's better to keep inlining it.

Due to explorations above, I've tweaked our code to work a little differently which I'll make comments below explaining

---

It also looks like we can remove the anymatch types that was used by chokidar before. I'm thinking perhaps that can be a follow-up.

[bluwy]

I removed this export because initially it wasn't exported by chokidar. It feels kinda rare to use this and I don't see it publicly used anywhere on github. So I figured to remove this.

[bluwy]

Of course it has to be windows 🥲 I did get that error locally while developing, but the added await page.goto(viteTestUrl) fixed it for me. Not sure why not for windows.

EDIT: Looks like it's not necessarily windows now.

[bluwy]

I'm able to reproduce locally sometimes by updating the vitest.config.e2e.ts with:

1. procese.env.CI = true
2. test.minWorkers: 1 and test.maxWorkers: 1

And after adding some loggings, here's what I got:

stdout | playground/hmr/__tests__/hmr.spec.ts > should hmr when file is deleted and restored
edit child

watch change /Users/bjorn/Work/oss/vite/playground-temp/hmr/file-delete-restore/child.js

edit parent
delete child

watch change /Users/bjorn/Work/oss/vite/playground-temp/hmr/file-delete-restore/parent.js

add child
edit parent

watch change /Users/bjorn/Work/oss/vite/playground-temp/hmr/file-delete-restore/parent.js
watch change /Users/bjorn/Work/oss/vite/playground-temp/hmr/file-delete-restore/child.js

add child/parent and edit child/parent are logged from the test. watch change/add/delete are logged from the fs watcher hooks.

From what I can tell, chokidar (or node fs) is collapsing the delete child and add child into a single file change event rather than 2 delete and add event. Perhaps it's related to paulmillr/chokidar#1361

[sapphi-red]

📝 Note to reviewers: chokidar now has ESM files so we don't need to patch require.

[sapphi-red]

📝 Note to reviewers: chokidar no longer uses fsevents (uses fs.watch for macos as well)

[sapphi-red]

This will break these: https://github.com/ElMassimo/vite-plugin-full-reload/blob/00045424209f8f9bef260047da1e9a73afd78f43/src/index.ts#L48, https://github.com/search?q=watch.disableGlobbing+NOT+is%3Afork&type=code
Probably fine but just to point it out.

[bluwy]

Adding a timeout seems to make it more stable, though a bit unfortunate to have it. What's described in #18453 (comment) was causing the issue, and a timeout after the initial delete needs to be long enough for the fs to detect a deletion.

[bluwy]

/ecosystem-ci run

[vite-ecosystem-ci]

📝 Ran ecosystem CI on 3ceb738: Open

suite	result	latest scheduled
redwoodjs	❌ failure	❌ failure
remix	❌ failure	❌ failure
sveltekit	❌ failure	❌ failure
vike	❌ failure	❌ failure
vite-environment-examples	❌ failure	✅ success
vitest	❌ failure	❌ failure

✅ analogjs, astro, histoire, ladle, laravel, marko, nuxt, previewjs, quasar, qwik, rakkas, storybook, unocss, vite-plugin-pwa, vite-plugin-react, vite-plugin-react-swc, vite-plugin-svelte, vite-plugin-vue, vite-setup-catalogue, vitepress, vuepress