Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSDK-9445: move generated python model out of main #4776

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

purplenicole730
Copy link
Member

@purplenicole730 purplenicole730 commented Feb 6, 2025

Changes:

  • replaced unused ModuleInputs.ModelLowercase with new ModelSnake
  • split src/main.py to be src/main.py and src/models/<modelSnake>.py
  • flyby import fixes

Testing:

  1. generated a Python module: Module successfully generated at temporary
  2. changed do_command() to return {"hi": "nicole"}
  3. ran this module on a local machine
    2025-02-06T20:13:23.519Z INFO rdk.modmanager.temporary modmanager/manager.go:1286 Registering component API and model from module {"module":"temporary","API":"rdk:component:sensor","model":"ns:temporary:hello-sensor"}
  4. called sensor.do_command
    sensor get_readings return value: {'hi': 'nicole'}
image

@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Feb 6, 2025
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Feb 6, 2025
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Feb 6, 2025
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants