Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSDK-9090 clarify package cleanup #4542

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

RSDK-9090 clarify package cleanup #4542

wants to merge 3 commits into from
+39 −20

Conversation

maximpertsov
Copy link
Contributor

@maximpertsov maximpertsov commented Nov 8, 2024 •
edited
Loading

Summary

Refactor and add documentation around package file cleanup logic.

Flyby Changes

Convert multierr.XXX -> errors.Join

Context

#4457 (comment)

@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Nov 8, 2024
abe-winter
abe-winter approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@abe-winter abe-winter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like non-breaking refactor

is there test coverage for commonCleanup? (not a merge blocker, just curious)

@maximpertsov
Copy link
Contributor Author

looks like non-breaking refactor

is there test coverage for commonCleanup? (not a merge blocker, just curious)

We do thankfully. This test file has a bunch tests that cover. For example, this specific test validates sync and delete directly:

rdk/robot/packages/cloud_package_manager_test.go

Line 176 in 6d17e17

t.Run("sync and clean should remove file", func(t *testing.T) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abe-winter abe-winter abe-winter approved these changes

@michaellee1019 michaellee1019 michaellee1019 approved these changes

Assignees
No one assigned
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maximpertsov @michaellee1019 @abe-winter @viambot