Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APP-6752: Add 'fragmentContents' and deprecate 'old' in FragmentHistoryEvent #578

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

ohEmily
Copy link
Member

@ohEmily ohEmily commented Oct 25, 2024

APP-6752

We do not want docs in the fragment_history collection to include metadata that is shared with the doc in the fragment collection. These duplicated fields are creating a bug in the UI and allowing rollbacks to versions on no-op changes made to immutable fields.

@github-actions github-actions bot added the safe to test committer is a member of this org label Oct 25, 2024
@ohEmily
Copy link
Member Author

ohEmily commented Oct 25, 2024

iteration note to self: make up-backend chokes on these changes as follows:

data/data.go:2305:21: cannot use *old (variable of type Fragment) as FragmentContents value in struct literal
data/models.go:1076:13: cannot use oldFragmentContentsProto (variable of type *structpb.Struct) as *"go.viam.com/api/app/v1".Fragment value in struct literal
data/test_helpers.go:278:40: unknown field Fragment in struct literal of type Fragment
data/test_helpers.go:828:3: unknown field Fragment in struct literal of type Fragment
make[1]: *** [up-app-local-db] Error 1
make[1]: *** Waiting for unfinished jobs....

edit: going to be a bit less ambitious

@ohEmily ohEmily added the ready-for-protos add this when you want protos to compile on every commit label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protos-compiled ready-for-protos add this when you want protos to compile on every commit safe to test committer is a member of this org
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant