Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Env values storing as number #3893

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

naman-bruno
Copy link
Contributor

Description

Addressing issue: #3859

If a user stored any number using bru.setGlobalEnvVar or bru.setEnvVar, the GUI environment variable would stop working entirely. To resolve this issue, I have implemented typecasting of values to strings before storing them.

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

@pooja-bruno
Copy link
Collaborator

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants