Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.70.17 sdist has python-tag = py313 hardcoded, rendering it incompatible with other Python versions #196

Open
mgorny opened this issue Oct 5, 2024 · 4 comments · May be fixed by #197
Open

Comments

@mgorny
Copy link

mgorny commented Oct 5, 2024

For example, using Python 3.12:

$ pip install --no-binary=multiprocess multiprocess==0.70.17
Collecting multiprocess==0.70.17
  Using cached multiprocess-0.70.17.tar.gz (1.8 MB)
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Preparing metadata (pyproject.toml) ... done
Requirement already satisfied: dill>=0.3.9 in ./venv/lib/python3.12/site-packages (from multiprocess==0.70.17) (0.3.9)
Building wheels for collected packages: multiprocess
  Building wheel for multiprocess (pyproject.toml) ... done
  Created wheel for multiprocess: filename=multiprocess-0.70.17-py313-none-any.whl size=147987 sha256=99b8a80bfdf46838b858e45193184c2054452d36ab7375f60de07ccb79e75fce
  Stored in directory: /home/mgorny/.cache/pip/wheels/dc/81/fa/c946c329f0033701d97715d4fdd2d217c495d1cbc6717c9c81
Successfully built multiprocess
Installing collected packages: multiprocess
Successfully installed multiprocess-0.70.17
$ pip check
multiprocess 0.70.17 is not supported on this platform

Note that it incorrectly produced a py313 wheel.

@mmckerns
Copy link
Member

mmckerns commented Oct 6, 2024

Ah, ok, I must have uploaded the wrong source tarball (i.e. the one built when building the 3.13 wheel). In that case, I'll release a 0.70.17.1

mgorny added a commit to mgorny/multiprocess that referenced this issue Oct 9, 2024
Enforce correct python tags for pure Python wheels directly from
`setup.py`.  This should be more reliable than the current approach.
While at it, switch to correct tags for each platforms -- CPython
uses "cp" (which unlike "py" is not accepted for PyPy), and PyPy can use
pure "pp" without platform specifiers (since no extensions are
installed).

Fixes uqfoundation#196
@mgorny mgorny linked a pull request Oct 9, 2024 that will close this issue
4 tasks
@mgorny
Copy link
Author

mgorny commented Oct 9, 2024

I've played a bit and I was able to control the tags from setup.py automatically, which should avoid this kind of problem in the future. I've filed #197 for this.

@sahiljhawar
Copy link

@mmckerns I am having the same issue during conda build process. Can you please push a fix? For now I can restrict to previous version in my recipe.

@mmckerns
Copy link
Member

mmckerns commented Nov 9, 2024

@sahiljhawar: I will get to a new release for multiprocess with this corrected as soon as I can. I'm on some travel and haven't had an opportunity post-release. It might take another week to get to it, but it's at the top of my to do list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants