Skip to content

Commit

Permalink
enforce correct python tags for pure wheels from setup.py
Browse files Browse the repository at this point in the history
Enforce correct python tags for pure Python wheels directly from
`setup.py`.  This should be more reliable than the current approach.
While at it, switch to correct tags for each platforms -- CPython
uses "cp" (which unlike "py" is not accepted for PyPy), and PyPy can use
pure "pp" without platform specifiers (since no extensions are
installed).

Fixes uqfoundation#196
  • Loading branch information
mgorny committed Oct 9, 2024
1 parent 1411ef0 commit 6008b92
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 0 deletions.
1 change: 1 addition & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
[build-system]
# Further build requirements come from setup.py via the PEP 517 interface
requires = [
"packaging",
"setuptools>=42",
]
build-backend = "setuptools.build_meta"
10 changes: 10 additions & 0 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,7 @@ def has_ext_modules(foo):

def run_setup(with_extensions=True):
extensions = []
options = {}
if with_extensions:
extensions = [
Extension(
Expand All @@ -232,6 +233,14 @@ def run_setup(with_extensions=True):
depends=glob.glob('%s/*.h' % srcdir) + ['setup.py'],
),
]
else:
import packaging.tags

tag_name = packaging.tags.interpreter_name()
tag_version = packaging.tags.interpreter_version()
options['bdist_wheel'] = {
'python_tag':tag_name+tag_version,
}
packages = find_packages(
where=pkgdir,
exclude=['ez_setup', 'examples', 'doc',],
Expand Down Expand Up @@ -276,6 +285,7 @@ def run_setup(with_extensions=True):
packages=packages,
package_dir={'': pkgdir},
ext_modules=extensions,
options=options,
)
# add dependencies
depend = [dill_version]
Expand Down

0 comments on commit 6008b92

Please sign in to comment.