-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update wollok-ts version #153
base: master
Are you sure you want to change the base?
Conversation
@@ -18,7 +18,7 @@ const Inspect = () => { | |||
try { | |||
const expression = parse.Expression.tryParse(expressionText) | |||
expression.forEach((node, parent) => { | |||
if(parent) node.cache.set('parent()', parent) | |||
if(parent) node.parent = parent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FerRomMu si querés mira este cambio a ver si te parece que esta bien
@@ -10,7 +10,7 @@ export function nodeLabel(node: Node): string { | |||
Method: node => `${node.name}/${node.parameters.length}`, | |||
Field: node => `${node.name}`, | |||
Variable: node => `${node.name}`, | |||
Body: node => nodeLabel(node.parent()), | |||
Body: node => nodeLabel(node.parent), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FerRomMu este también
@FerRomMu La version wollok-ts 3.1.2, sería actualmente esta rama de wollok-ts con esta rama de wollok-language |
Cabe destacar que a mi este branch me falla (pesé a que a juli le anda). Específicamente me lanza un error en: wollok-run-client/src/components/debugger/SourceDisplay.tsx Lines 16 to 18 in 951f4f0
El error en cuestion es: Lo pude solucionar así, que en realidad simplemente busca evitar que salte ese error, pero sigo haciendo lo mismo (dicho de otro modo es una especie de cambio sintáctico para que el compilador no me tire error): const currentSourceMap = currentNode.sourceMap? currentNode.sourceMap : undefined
const highlight = (code: string) => currentNode.isSynthetic() ? code :
`${code.slice(0, currentSourceMap!.start.offset)}<b id='current'>${code.slice(currentSourceMap!.start.offset, currentSourceMap!.end.offset)}</b>${code.slice(currentSourceMap!.end.offset)}` Lo llamativo es que a @julimr no le fallaba el run-client y a mi sí (hasta que hice el cambio). Por eso no commitee el cambio. |
Actualizamos la versión de wollok-ts de 3.0.6 a 3.1.1