Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ngfw 14954 dbl api support #905

Open
wants to merge 13 commits into
base: ngfw-14895
Choose a base branch
from
Open

Conversation

DhirajM09
Copy link
Contributor

Changes:

  1. Added model class DynamicList for storing the Dynamic Block List's information in settings file
  2. Adding default Dynamic List's in settings on app installation
  3. Modified setSettings method in DynamicListsApp class to populate the id of newly added dynamic lists from UI/API
  4. Added DynamicListsManager class. It will be used to configure Iptables.
  5. Added a dbl-setup.sh and dbl-cleanup.sh scripts to add required rules on app initiation and cleaning up on app power off.

Copy link
Contributor

@mayur-dhande mayur-dhande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments, and see if you can add bare minimum logging for start, stop , set settings at INFO level, just to get an insight of the working flow by looking at the logs.

Copy link
Contributor

@mayur-dhande mayur-dhande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion, Hyphen variable should be renamed to HYPHEN since its a constant.

DhirajM09 and others added 7 commits January 17, 2025 11:11
* NGFW-14988 updated DBL reports

* NGFW-14988 added translation entries

* NGFW-14993 added reports under Dynamic Lists category

* NGFW-14993 updated time data column condition

* NGFW-15012 : Renamed Dynamic Lists app to Dynamic Blocklists (#924)

* NGFW-15012 : Renamed Dynamic Lists app to Dynamic Blocklists

* NGFW-15012: updated java file name

---------

Co-authored-by: AristaKB <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants