-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ngfw 14954 dbl api support #905
base: ngfw-14895
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments, and see if you can add bare minimum logging for start, stop , set settings at INFO level, just to get an insight of the working flow by looking at the logs.
dynamic-lists/src/com/untangle/app/dynamic_lists/DynamicListsApp.java
Outdated
Show resolved
Hide resolved
dynamic-lists/src/com/untangle/app/dynamic_lists/DynamicListsApp.java
Outdated
Show resolved
Hide resolved
dynamic-lists/src/com/untangle/app/dynamic_lists/DynamicListsApp.java
Outdated
Show resolved
Hide resolved
dynamic-lists/src/com/untangle/app/dynamic_lists/DynamicListsApp.java
Outdated
Show resolved
Hide resolved
dynamic-lists/src/com/untangle/app/dynamic_lists/DynamicListsApp.java
Outdated
Show resolved
Hide resolved
dynamic-lists/src/com/untangle/app/dynamic_lists/DynamicListsApp.java
Outdated
Show resolved
Hide resolved
dynamic-lists/src/com/untangle/app/dynamic_lists/DynamicListsManager.java
Outdated
Show resolved
Hide resolved
dynamic-lists/src/com/untangle/app/dynamic_lists/DynamicListsManager.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small suggestion, Hyphen variable should be renamed to HYPHEN since its a constant.
…b file while cleanup
* NGFW-14988 updated DBL reports * NGFW-14988 added translation entries * NGFW-14993 added reports under Dynamic Lists category * NGFW-14993 updated time data column condition * NGFW-15012 : Renamed Dynamic Lists app to Dynamic Blocklists (#924) * NGFW-15012 : Renamed Dynamic Lists app to Dynamic Blocklists * NGFW-15012: updated java file name --------- Co-authored-by: AristaKB <[email protected]>
Changes:
DynamicList
for storing the Dynamic Block List's information in settings fileDynamicListsApp
class to populate the id of newly added dynamic lists from UI/APIDynamicListsManager
class. It will be used to configure Iptables.dbl-setup.sh
anddbl-cleanup.sh
scripts to add required rules on app initiation and cleaning up on app power off.