Use strong types for key and bare item integer, decimal, token, and string #137
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an updated version of #102 that takes the following approach:
BareItem
andRefBareItem
contain only fully validated types.Into
andTryInto
simplify creation of these types from unvalidated inputs, including at compile-time usingconst fn
.rust_decimal::Decimal
is replaced with ansfv::Decimal
type that simply wraps the newInteger
type, as an SFV decimal is 12 integral digits and 3 fractional digits, while an SFV integer is 15 decimal digits.sfv::{Key, String, Token}
types are the owned equivalents of the newsfv::{KeyRef, StringRef, TokenRef}
types, analogous toVec<T>
vs[T]
.As part of #119, we will likewise introduce an
sfv::Date
type that wrapsInteger
.Fixes #98