Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support clickToComponent #53

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

QDyanbing
Copy link
Contributor

@QDyanbing QDyanbing commented Nov 15, 2024

support clickToComponent. Close #50


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests and other checks with pnpm ci

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features and fix bugs should all be patch before we release 0.1.0. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Nov 15, 2024

🦋 Changeset detected

Latest commit: 2b6e12e

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sorrycc sorrycc merged commit e6ed386 into umijs:master Nov 15, 2024
3 checks passed
@github-actions github-actions bot mentioned this pull request Nov 15, 2024
@@ -51,6 +51,7 @@
"@umijs/mako": "^0.9.4",
"c12": "^2.0.1",
"chokidar": "^4.0.1",
"click-to-react-component": "1.1.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

提一个毫不相关的,看到这个就生气,这几天全是
"resolutions": {
"click-to-react-component":"1.1.0"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support clickToComponent
3 participants