TokenManager, AccessToken migration #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -145,6 +149,12 @@ public final class KeychainUtility: KeychainUtilityProtocol { | |||
| ) == noErr | |||
| } | |||
|
|
|||
| /// Updates the accessGroup used for subsequent operations | |||
| /// - Parameter accessGroup: The new accessGroup | |||
| public func setAccessGroup(_ accessGroup: String) { | |||
There was a problem hiding this comment.
can we update the API to receive more than just the key instead? maybe a struct with the key and access group
There was a problem hiding this comment.
I was mostly keeping parity with the legacy API since it made migration easier, but I can update to accept this as a parameter with a default nil value.
There was a problem hiding this comment.
Updated. Please take a look @renan-ssoares
renan-ssoares
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New TokenManager and AccessToken classes were added in a previous PR. This PR migrates any classes still using TokenManager_DEPRECATED and AccessToken_DEPRECATED to the new ones. It also removes the deprecated classes.
Changes
AccessGroup Support
To keep feature parity, support was added for setting a custom access group when performing any keychain operations.
Updated call sites
UberCore and UberRides classes (RidesRequestView, LoginManager, etc.) were updated to reference a new instance of TokenManager instead of the static TokenManager_DEPRECATED. Logic and functionality should remain the same.
Note: LoginManager will be removed eventually.
Additional AccessToken initializers
An AccessToken extension with custom inits was added to support UberRides classes.
Testing
token_migration.mov