[WIP] Create UnsafeNonFatal for use in the fiber runtime #4263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR!! Sorry, would you mind re-targeting to the |
kapunga
force-pushed
the
4254-custom-non-fatal
branch
from
569d1c9 to
ee6f0b8
Compare
Done. |
kapunga
force-pushed
the
4254-custom-non-fatal
branch
from
3970f74 to
58a9c5d
Compare
durban
reviewed
Feb 3, 2025
| * code, as handling interrupts gracefully is the responsibility of the runtime, so | ||
| * [[UnsafeNonFatal]] should only be used in the fiber runtime. | ||
| */ | ||
| object UnsafeNonFatal { |
There was a problem hiding this comment.
Does this need to be public?
| /** | ||
| * Returns Some(t) if RuntimeNonFatal(t) == true, otherwise None | ||
| */ | ||
| def unapply(t: Throwable): Option[Throwable] = Some(t).filter(apply) |
There was a problem hiding this comment.
If t is considered fatal, I think we shouldn't allocate a new object (it could be, e.g., an OutOfMemoryError).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a custom
NonFataltype for use in the fiber runtime. This is needed because while application code generally shouldn't catchInterruptedException, the fiber runtime is responsible for dealing with interrupts gracefully.Initially I considered naming this
RuntimeNonFatal, however I thinkUnsafeNonFatalmakes it really clear that you shouldn't use it without knowing what you are doing.Will resolve #4254