n-modal 新增 max-height 属性
#6759
Open
n-modal 新增 max-height 属性
#6759
+228
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
因为没办法预览，如果加上 max-height 滚动条样式还是原来的 NScrollBar 吗？ |
|
传了max-height，外层那个scroll会被替换成div，不然不好兼容传%的。 不传就还是原来外层scroll的逻辑，兼容以前没传的 |
|
|
|
@jahnli 这么写不可以吗，外层就是要scrollbar吗？ |
个人觉得如果能实现 scrollbar 是最好的，不然感觉是个 break change ，用户有一些 scrollbar 的属性或者发现样式变了 |
|
嗯，那我再想想，用户传%的话滚动条不好处理。我晚点对传%的处理一下 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
不传maxheight，按原来的外部滚动条逻辑！传了maxheight，替换滚动条成divdialog增加flex布局
如果maxheight传string类型最后一位是%，套一层VResizeObserver计算body-wrapper的高度（我试了一下120px%，也按120%计算了，挺正常）
保留外部的scrollbar
close #4848