Rename SwiftProtobuf to avoid issue

[dinhnhat0401]

Description

Change SwiftProtobuf lib name to avoid conflict with other Swift SPM packages.
This will solve this issue: #2088

How to test

Should have no change to functionality.

Types of changes

Change SwiftProtobuf lib name to avoid conflict with other Swift SPM packages.

Checklist

• Create pull request as draft initially, unless its complete.
• Add tests to cover changes as needed.
• Update documentation as needed.
• If there is a related Issue, mention it in the description.

If you're adding a new blockchain

• I have read the guidelines for adding a new blockchain.

[satoshiotomakan]

Hi @dinhnhat0401, thank you for opening the PR!
Let's see if the Swift CI passes. Then I'll discuss internally if the renamed WalletCoreSwiftProtobuf does not break backward compatibilities.

[dinhnhat0401]

@satoshiotomakan thanks. I think all the CI passed (except one for not related issue)
I have tested the setting with our project and it seems working fine.

[satoshiotomakan]

Hi @dinhnhat0401, unfortunately, we cannot merge the PR since we do not have time to well test it.
Ideally, we should have a CI - a demo app to consume the local SPM package (with some simple tests), then we can see if that change would break our iOS app or not.
We plan to work on it the next year

[dinhnhat0401]

Happy new year.
@satoshiotomakan just want to follow up. Any update on this?

[doovers]

@satoshiotomakan I'm also interested in a resolution to this. Any progress?

[satoshiotomakan]

Hi @doovers, @dinhnhat0401, sorry for the late reply
Unfortunately, we do not have resources at the moment to complete the testing. We track this issue, so once we finish with all our priority tasks, we'll move on this PR

[dimitris-c]

Hey, so this just renames the library, at runtime you'll get a warning since the system can't determine which framework to actually use.

[dinhnhat0401]

@dimitris-c do you have any suggestion to make it explicitly defined?

[dimitris-c]

not off the top of my head, a lot of maintenance would be required to rename the SwiftProtobuf library for it to be unique

[dinhnhat0401]

@satoshiotomakan any updates on this?

[tamimattafi]

Hello! Any updates on this?

[podkovyrin]

I made a working proof of concept, renaming the SwiftProtobuf dependency during integration. This was mainly achieved by providing a local TWSwiftProtobuf.podspec with an updated library name and minor changes in the build scripts. All related changes can be found here. The working SPM package of the latest wallet-core version was released. It can be integrated into a project with an existing SwiftProtobuf SPM dependency in the same way as stated in the documentation.

Unfortunately, this breaks CocoaPods compatibility (WalletCore.podspec) since the podspec specification does not allow for specifying a local pod's dependency. I also tried a different approach to rename SwiftProtobuf on the fly (during pod install) by adding pre/post-install hooks in the Podfile, but it ended up with a broken framework built.
In case of sunsetting CocoaPods support, I can make a PR fixing this issue.

[satoshiotomakan]

Hi @podkovyrin, thanks for the update, and especially for the PoC! We'll test if it doesn't break our iOS app, and then borrow the changes 👍

[dimitris-c]

Thanks @podkovyrin I tried on an empty project with your release and Firebase via SPM and no complaints from Xcode or runtime warnings