Turn off JS Minification for Heroku #238
Conversation
| def config_js_compressor | ||
| production_config = "config/environments/production.rb" | ||
|
|
||
| inject_into_file production_config, before: "end\n" do <<-RUBY |
There was a problem hiding this comment.
Block body expression is on the same line as the block start.
|
@seanpdoyle to be clear, this is only disabling the Rails-side minification, correct? JS is still being minified by Ember? After reading #123 that was my impression, but wanted to confirm my understanding. |
seanpdoyle
force-pushed
the
sd-heroku-minify
branch
from
70321e5 to
3ea4218
Compare
|
What happens if I'm using Ember for part of my app but using jquery and a few other things for another area of my app? Isn't this eliminating the minification there? |
|
@geoffharcourt that's correct. There are PRs (rondale-sc/ember-cli-rails-addon#12, rondale-sc/ember-cli-rails-addon#16) that disable minification on the addon side of things, but they do it automatically and implicitly, without giving the consumer the chances to make their decision. There still a big decision to be made here, but I'd like to test it out on Heroku first to see how it goes. |
|
@drapergeek yes, it is. Fortunately, since this is a generator, there will be diff noise. That diff noise could be reverted, and at that point you could manually set |
|
@drapergeek Ideally, on a greenfield app (like the one Geoff and I are working) you'd keep your assets on the frontend. |
That's an ideal situation. There are definitely cases where you want things to be split.
That's fine for our case but I worry that others won't see what is happening and they lose speed due to an oversight. Not sure how to rectify that issue while still fixing this problem though. |
|
@seanpdoyle I think a change to the README to clarify would be helpful, but the code side of this looks good. |
|
@drapergeek would you prefer disabling minification in EmberCLI -- relying on the Asset Pipeline for minification? |
Definitely not. Of the two options, I significantly prefer this. This really doesn't affect me since I deploy with ember-cli-deploy anyway. I'd leave on minification for our other stuff. I'm just concerned about others who don't notice what is happening. |
seanpdoyle
force-pushed
the
sd-heroku-minify
branch
from
3ea4218 to
f8e36e7
Compare
Given the outcome of [#123] and [#124], we don't take a stand on where minification should happen. However, to make sure that Heroku deployments don't take too long, the generator can disable Rails-side minification. The benefit of doing this in the generator (as opposed to automatically in [the addon]) is that the change will introduce diff noise, which is explicit and easy to back out of. [#123]: #123 [#124]: #124 [the addon]: https://github.com/rondale-sc/ember-cli-rails-addon/blob/2f2a47efe6e81a2bcd43ec9ff0f89fc18bed5a03/index.js#L25-L32
seanpdoyle
force-pushed
the
sd-heroku-minify
branch
from
f8e36e7 to
21f701f
Compare
Given the outcome of #123 and #124, we don't take a stand on where
minification should happen.
However, to make sure that Heroku deployments don't take too long, the
generator can disable Rails-side minification.
The benefit of doing this in the generator (as opposed to automatically
in the addon) is that the change will introduce diff noise, which is
explicit and easy to back out of.