Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(eslint): add @typescript-eslint/naming-convention to lint generic #385

Merged
merged 3 commits into from
Nov 22, 2023
Merged

ci(eslint): add @typescript-eslint/naming-convention to lint generic #385

merged 3 commits into from
Nov 22, 2023

Conversation

manudeli
Copy link
Member

@manudeli manudeli commented Nov 20, 2023 •
edited
Loading

fix #384

Overview

I added eslint rule to lint TypeScript generic conventionally
Thanks to @juliusmarminge https://twitter.com/jullerino/status/1726532233824284741

PR Checklist

  • I did below actions if need
  1. I read the Contributing Guide
  2. I added documents and tests.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 20, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: efe2ac6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@manudeli manudeli self-assigned this Nov 20, 2023
@vercel Vercel
Copy link

vercel bot commented Nov 20, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2023 11:02am
visualization ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2023 11:02am

manudeli
manudeli commented Nov 20, 2023
View reviewed changes
packages/react-query/src/useSuspenseQueries.ts
Comment on lines +1 to +2
// TODO: remove this eslint
/* eslint-disable @typescript-eslint/naming-convention */
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After removing enabled option in @suspensive/react-query, I will remove these comments

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Nov 20, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@codecov Codecov
Copy link

codecov bot commented Nov 20, 2023 •
edited
Loading

Codecov Report

Merging #385 (efe2ac6) into main (12d476b) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #385   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           23        23           
  Lines          846       846           
  Branches       144       144           
=========================================
  Hits           846       846
Components Coverage Δ
@suspensive/react 100.00% <100.00%> (ø)
@suspensive/react-query ∅ <ø> (∅)
@suspensive/react-await 100.00% <ø> (ø)

@manudeli manudeli marked this pull request as ready for review November 20, 2023 13:39
@vercel vercel bot temporarily deployed to Preview – docs November 20, 2023 14:16 Inactive
@vercel vercel bot temporarily deployed to Preview – docs November 22, 2023 11:00 Inactive
@vercel vercel bot temporarily deployed to Preview – visualization November 22, 2023 11:02 Inactive
@manudeli manudeli merged commit 2fe8fa1 into main Nov 22, 2023
17 checks passed
@manudeli manudeli deleted the ci/ts-generic-eslint branch November 22, 2023 11:11
manudeli added a commit that referenced this pull request Aug 3, 2024
@manudeli
ci(eslint): add @typescript-eslint/naming-convention to lint generic (#…
6379953 
…385)

fix #384 

# Overview

<!--
    A clear and concise description of what this pr is about.
 -->

I added eslint rule to lint TypeScript generic conventionally
Thanks to @juliusmarminge
https://twitter.com/jullerino/status/1726532233824284741

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/suspensive/react/blob/main/CONTRIBUTING.md)
2. I added documents and tests.
manudeli added a commit that referenced this pull request Aug 3, 2024
@manudeli
ci(eslint): add @typescript-eslint/naming-convention to lint generic (#…
0c6997f 
…385)

fix #384 

# Overview

<!--
    A clear and concise description of what this pr is about.
 -->

I added eslint rule to lint TypeScript generic conventionally
Thanks to @juliusmarminge
https://twitter.com/jullerino/status/1726532233824284741

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/suspensive/react/blob/main/CONTRIBUTING.md)
2. I added documents and tests.
manudeli added a commit that referenced this pull request Aug 3, 2024
@manudeli
ci(eslint): add @typescript-eslint/naming-convention to lint generic (#…
c21c190 
…385)

fix #384 

# Overview

<!--
    A clear and concise description of what this pr is about.
 -->

I added eslint rule to lint TypeScript generic conventionally
Thanks to @juliusmarminge
https://twitter.com/jullerino/status/1726532233824284741

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/suspensive/react/blob/main/CONTRIBUTING.md)
2. I added documents and tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okinawaa okinawaa Awaiting requested review from okinawaa

@minsoo-web minsoo-web Awaiting requested review from minsoo-web

Assignees

@manudeli manudeli

Labels
@suspensive/react @suspensive/react-await @suspensive/react-query
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: TypeScript generic eslint
1 participant
@manudeli