-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: auto-attach crowtty when running x86 kernel #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
; Conflicts: ; Cargo.lock ; tools/x86_64-bootimager/Cargo.toml ; tools/x86_64-bootimager/src/lib.rs ; tools/x86_64-bootimager/src/main.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds code in the x86 bootimage runner to automatically
attach crowtty to the QEMU virtual serial port when running in QEMU
(unless asked politely not to). Doing this required turning
crowtty
into a library, so it could be used as a dependency of
x86_64-bootimager
.Since we don't have a working UART driver in the x86 kernel yet (see
#222), the serial port currently only gets us output from the
bootloader, and we can't currently speak SerMux with the running mnemOS
VM. But, I'm gonna go add a serial driver next hopefully.