Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*cake.qos: support unlimited bandwidth #177

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

intelfx
Copy link

@intelfx intelfx commented Jan 27, 2025

No description provided.

@intelfx intelfx force-pushed the work/unlimited-bandwidth branch from f0fc461 to 035a63d Compare January 27, 2025 03:19
@moeller0
Copy link
Collaborator

Quick note, did anyone test what this does with with fq_codel as selected qdisc?

@tohojo
Copy link
Owner

tohojo commented Jan 27, 2025

Erm, what's the point of supporting "unlimited" bandwidth? The whole point of sqm-scripts is to setup traffic shaping, without that you could just install a root qdisc, why do you need the complexity of sqm-scripts for this use case?

@intelfx
Copy link
Author

intelfx commented Jan 27, 2025

The whole point of sqm-scripts is to setup traffic shaping, without that you could just install a root qdisc, why do you need the complexity of sqm-scripts for this use case?

@tohojo Because this tool is a common abstraction that simplifies management of the tc subsystem for both cases. As I understand, at least CAKE is explicitly designed with support for running it without the shaping part:

IF you want to run at line rate for your device, relying instead on backpressure from the ethernet driver (and hopefully BQL) don’t specify the bandwidth.

@tohojo
Copy link
Owner

tohojo commented Feb 10, 2025

Sure, cake can run in unlimited mode just fine, but I'm not sure how much of a 'simplification' it is? I mean, there's literally a single sysctl you can set to select default qdisc for the system, which has the added benefit of also correctly installing an mq qdisc on multi-queue devices, with the selected qdisc as the sub-qdisc for each HW queue.

What's the full config you are using with 'unlimited' bandwidth? Are you setting any other cake parameters?

In any case, if we support this, we should also support this for non-cake qdiscs. Meaning that for fq_codel et al, we should skip the HTB/TBF setup and just install the qdisc on the root interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants