Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(editor): use model coord system in worker renderer #9969

Merged
merged 7 commits into from
Feb 6, 2025

Conversation

doodlewind
Copy link
Member

@doodlewind doodlewind commented Feb 5, 2025

In original PoC, the canvas is rendered using DOM coords from getBoundingClientRect directly, which is not scalable. This PR switches to using model coords when rendering offscreen text sections.

Copy link

graphite-app bot commented Feb 5, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.02%. Comparing base (db1fcf4) to head (e359e24).
Report is 5 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9969      +/-   ##
==========================================
- Coverage   53.03%   53.02%   -0.01%     
==========================================
  Files        2257     2257              
  Lines      103235   103235              
  Branches    17159    17156       -3     
==========================================
- Hits        54750    54742       -8     
- Misses      47104    47111       +7     
- Partials     1381     1382       +1     
Flag Coverage Δ
server-test 76.44% <ø> (-0.02%) ⬇️
unittest 31.84% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@doodlewind doodlewind marked this pull request as ready for review February 5, 2025 22:23
@doodlewind doodlewind requested a review from a team as a code owner February 5, 2025 22:23
@graphite-app graphite-app bot requested review from a team February 5, 2025 22:24
@doodlewind doodlewind merged commit 077a1b3 into canary Feb 6, 2025
65 checks passed
@doodlewind doodlewind deleted the doodl/edgeless-rect branch February 6, 2025 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants