Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(editor): refactor linkPreviewer as an extension and remove bookmark service #9754

Conversation

donteatfriedrice
Copy link
Member

@donteatfriedrice donteatfriedrice commented Jan 17, 2025

Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@donteatfriedrice donteatfriedrice marked this pull request as ready for review January 17, 2025 07:40
@donteatfriedrice donteatfriedrice requested a review from a team as a code owner January 17, 2025 07:40
@graphite-app graphite-app bot requested review from a team January 17, 2025 07:40
@donteatfriedrice donteatfriedrice force-pushed the 01-17-refactor_editor_refactor_linkpreviewer_as_an_extension_and_remove_bookmark_service branch 2 times, most recently from b9a7ee1 to 003d354 Compare January 17, 2025 07:45
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 53.23%. Comparing base (cc29582) to head (4bd43a6).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
blocksuite/affine/block-bookmark/src/utils.ts 0.00% 2 Missing ⚠️
...fine/shared/src/services/link-previewer-service.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9754      +/-   ##
==========================================
- Coverage   53.24%   53.23%   -0.02%     
==========================================
  Files        2195     2194       -1     
  Lines       98820    98807      -13     
  Branches    16752    16751       -1     
==========================================
- Hits        52620    52601      -19     
+ Misses      44822    44796      -26     
- Partials     1378     1410      +32     
Flag Coverage Δ
server-test 78.52% <ø> (ø)
unittest 32.05% <37.50%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@donteatfriedrice donteatfriedrice marked this pull request as draft January 17, 2025 07:55
@donteatfriedrice donteatfriedrice force-pushed the 01-17-refactor_editor_refactor_linkpreviewer_as_an_extension_and_remove_bookmark_service branch 2 times, most recently from 5cc8da3 to d789ee8 Compare January 17, 2025 10:16
@donteatfriedrice donteatfriedrice marked this pull request as ready for review January 17, 2025 10:18
@donteatfriedrice donteatfriedrice force-pushed the 01-17-refactor_editor_refactor_linkpreviewer_as_an_extension_and_remove_bookmark_service branch 2 times, most recently from 2a7f75c to 04a1809 Compare January 20, 2025 02:12
@donteatfriedrice donteatfriedrice force-pushed the 01-17-refactor_editor_refactor_linkpreviewer_as_an_extension_and_remove_bookmark_service branch from 04a1809 to 856aa8a Compare January 20, 2025 02:34
Copy link

graphite-app bot commented Jan 20, 2025

Merge activity

@donteatfriedrice donteatfriedrice force-pushed the 01-17-refactor_editor_refactor_linkpreviewer_as_an_extension_and_remove_bookmark_service branch from 856aa8a to 4bd43a6 Compare January 20, 2025 04:18
@graphite-app graphite-app bot merged commit 4bd43a6 into canary Jan 20, 2025
61 checks passed
@graphite-app graphite-app bot deleted the 01-17-refactor_editor_refactor_linkpreviewer_as_an_extension_and_remove_bookmark_service branch January 20, 2025 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants