fix(core): move openinapp guard to workspace scope #9751
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## canary #9751 +/- ##
==========================================
+ Coverage 53.10% 53.39% +0.29%
==========================================
Files 2185 2189 +4
Lines 98175 98883 +708
Branches 16688 16720 +32
==========================================
+ Hits 52131 52801 +670
- Misses 44675 44717 +42
+ Partials 1369 1365 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -41,7 +41,7 @@ export const OpenInAppPage = ({ | |||
| const goToAppearanceSetting = useCallback( | |||
| (e: MouseEvent) => { | |||
| openHereClicked?.(e); | |||
| workspaceDialogService.open('setting', { | |||
| workspaceDialogService?.open('setting', { | |||
There was a problem hiding this comment.
it's not kinda proper to show [change in settings] in authentication pages
There was a problem hiding this comment.
It will not show on authentication mode. The button will only show when mode === 'open-doc'.
No description provided.