Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): optimize team workspace member management #9737

Open
wants to merge 2 commits into
base: canary
Choose a base branch
from

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented Jan 16, 2025

close AF-2106 AF-2077 AF-2089

feat(core): handle need more seat status

feat(core): prevent invite members when team plan is canceled

Copy link
Member Author

JimmFly commented Jan 16, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@JimmFly JimmFly changed the title feat(core): handle need more seat status feat(core): optimize team workspace member management Jan 16, 2025
@JimmFly JimmFly marked this pull request as ready for review January 16, 2025 11:59
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.67%. Comparing base (79fe687) to head (d449b09).
Report is 1 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9737      +/-   ##
==========================================
- Coverage   53.70%   53.67%   -0.04%     
==========================================
  Files        2249     2249              
  Lines      102223   102223              
  Branches    16910    16907       -3     
==========================================
- Hits        54901    54865      -36     
- Misses      45963    46000      +37     
+ Partials     1359     1358       -1     
Flag Coverage Δ
server-test 77.44% <ø> (-0.09%) ⬇️
unittest 31.97% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


const openWorkspace = useCallback(() => {
jumpToPage(inviteInfo.workspace.id, 'all', RouteLogic.REPLACE);
}, [inviteInfo.workspace.id, jumpToPage]);

useEffect(() => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use effect will run twice?
maybe move this to service

@JimmFly JimmFly force-pushed the jimmfly/0116/team-need-more-seat branch from 7758c10 to d449b09 Compare January 24, 2025 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants