-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): optimize team workspace member management #9737
base: canary
Are you sure you want to change the base?
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## canary #9737 +/- ##
==========================================
- Coverage 53.70% 53.67% -0.04%
==========================================
Files 2249 2249
Lines 102223 102223
Branches 16910 16907 -3
==========================================
- Hits 54901 54865 -36
- Misses 45963 46000 +37
+ Partials 1359 1358 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
||
const openWorkspace = useCallback(() => { | ||
jumpToPage(inviteInfo.workspace.id, 'all', RouteLogic.REPLACE); | ||
}, [inviteInfo.workspace.id, jumpToPage]); | ||
|
||
useEffect(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use effect will run twice?
maybe move this to service
7758c10
to
d449b09
Compare
close AF-2106 AF-2077 AF-2089
feat(core): handle need more seat status
feat(core): prevent invite members when team plan is canceled