Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add block for flat data #10009

Merged
merged 8 commits into from
Feb 7, 2025
Merged

Conversation

Saul-Mirone
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 51.13636% with 43 lines in your changes missing coverage. Please review.

Project coverage is 53.61%. Comparing base (b9ad53a) to head (5f457af).
Report is 2 commits behind head on zzj/refactor/table-block-data.

Files with missing lines Patch % Lines
...suite/affine/block-table/src/table-data-manager.ts 26.31% 28 Missing ⚠️
blocksuite/framework/store/src/model/store/crud.ts 58.33% 5 Missing ⚠️
...uite/framework/store/src/reactive/flat-native-y.ts 78.26% 3 Missing and 2 partials ⚠️
blocksuite/affine/block-table/src/commands.ts 42.85% 4 Missing ⚠️
...locksuite/framework/store/src/model/store/utils.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                        Coverage Diff                        @@
##           zzj/refactor/table-block-data   #10009      +/-   ##
=================================================================
- Coverage                          53.62%   53.61%   -0.01%     
=================================================================
  Files                               2271     2271              
  Lines                             104229   104247      +18     
  Branches                           17269    17276       +7     
=================================================================
+ Hits                               55888    55892       +4     
- Misses                             46977    46987      +10     
- Partials                            1364     1368       +4     
Flag Coverage Δ
server-test 77.50% <ø> (-0.02%) ⬇️
unittest 31.84% <28.40%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Saul-Mirone Saul-Mirone marked this pull request as ready for review February 7, 2025 15:56
@Saul-Mirone Saul-Mirone requested a review from a team as a code owner February 7, 2025 15:56
@graphite-app graphite-app bot requested review from a team February 7, 2025 15:56
@Saul-Mirone Saul-Mirone merged commit fc6ff11 into zzj/refactor/table-block-data Feb 7, 2025
63 checks passed
@Saul-Mirone Saul-Mirone deleted the fix-add-block branch February 7, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants