-
-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
llms/mistral: Implementing embeddings.EmbedderClient for Mistral and an example with PGVector #1086
Open
mathiasb
wants to merge
12
commits into
tmc:main
Choose a base branch
from
mathiasb:feature-mistral-embedding-pgvector
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I did a replace in my mod file for my local dev, and was unsure how to handle that in the PR, which I think is the reason for the CI failures. Happy to take pointers on if I should change something in my repo to fix it. KR |
…ents CreateEmbedding and the embeddings.EmbedderClient interface
Ok, I think good to go for reviewing. Also, as said earlier, any pointers or feedback welcome as this is my first PR in this project. |
FluffyKebab
reviewed
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the embeddings.EmbedderClient interface for mistral, using the "mistral-embed" model. There is an example, heavily inspired by the
openai-embeddings-example
of how it can be used with pgvector.PR Checklist
memory: add interfaces for X, Y
orutil: add whizzbang helpers
).Fixes #123
).golangci-lint
checks.