bedrockclient: add support for new Amazon Nova models #1083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements support of the new Amazon Nova models: * Nova Micro * Nova Lite * Nova Pro
|
Hi @tmc, any chance to get a review for these changes? (: |
FluffyKebab
reviewed
Jan 5, 2025
| @@ -39,6 +39,39 @@ const ( | |||
| // Languages: English (GA), Multilingual in 100+ languages (Preview). | |||
| ModelAmazonTitanTextExpressV1 = "amazon.titan-text-express-v1" | |||
|
|
|||
| // Amazon Nova Micro is a text only model that delivers the lowest latency responses at very low cost. | |||
| // It is highly performant at language understanding, translation, reasoning, code completion, | |||
| // brainstorming, and mathematical problem-solving. With its generation speed of over 200 tokens per second, | |||
There was a problem hiding this comment.
Maybe the language in these comments sound a little biased? I also think they could be shorter and focus more on the differences between the models.
There was a problem hiding this comment.
This can be put in a separate folder called testdata.
| content := output.Output.Message.Content | ||
| if len(content) == 0 { | ||
| return nil, errors.New("no results") | ||
| } else if stopReason := output.StopReason; stopReason != NovaCompletionReasonEndTurn && stopReason != NovaCompletionReasonStopSequence { |
There was a problem hiding this comment.
nit: the else is unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
memory: add interfaces for X, Yorutil: add whizzbang helpers).Fixes #123).golangci-lintchecks.This PR adds support for the new Amazon Nova models
The implementation is very similar to the anthropic provider (since they share some common structures and constraints)