Feature/llm multi prompt #1070
Open
Feature/llm multi prompt #1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jubeless
force-pushed
the
feature/llm-multi-prompt
branch
from
2492913 to
33faf24
Compare
Fix linter errors FIx linter comment Added backwards compatibility
jubeless
force-pushed
the
feature/llm-multi-prompt
branch
from
33faf24 to
8724ddd
Compare
FluffyKebab
reviewed
Jan 6, 2025
| } | ||
|
|
||
| return chain | ||
| } | ||
|
|
||
| func (c *LLMChain) EnableMultiPrompt() { |
There was a problem hiding this comment.
Maybe this should can be adjusted using a ChainCallOption?
| const _llmChainDefaultOutputKey = "text" | ||
| const ( | ||
| _llmChainDefaultOutputKey = "text" | ||
| _llmChainMultiPromptOutputKey = "choices" |
There was a problem hiding this comment.
Is it necessary to change the output key of the chain by default when using multipromt?
| if err != nil { | ||
| return nil, fmt.Errorf("llm generate content: %w", err) | ||
| } | ||
|
|
There was a problem hiding this comment.
It should be documented somewhere that output parsers does not work with multiprompt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support for multi-prompt calls in llms, while maintaining backward compatibility with the LLMChain implementation for the call function. That said we believe the default of
LLMChain.Callbehaviour should not flatten prompts into a single message.Key Features
Backward Compatibility
No breaking changes have been introduced. Tracing is optional and does not affect existing functionality when disabled.
PR Checklist
memory: add interfaces for X, Yorutil: add whizzbang helpers).Fixes #123).golangci-lintchecks.