Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(tidb-6.5) Do not set txn scope in snapshot #1572

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

ekexium
Copy link
Contributor

@ekexium ekexium commented Feb 11, 2025

Ref pingcap/tidb#59402

TxnScope should not be set to ReadReplicaScope.

@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 11, 2025
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Feb 12, 2025
@ti-chi-bot ti-chi-bot bot added the lgtm label Feb 12, 2025
Copy link

ti-chi-bot bot commented Feb 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, crazycs520

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 12, 2025
Copy link

ti-chi-bot bot commented Feb 12, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-12 06:35:45.583903977 +0000 UTC m=+424787.980126024: ☑️ agreed by cfzjywxk.
  • 2025-02-12 06:50:34.994435889 +0000 UTC m=+425677.390657948: ☑️ agreed by crazycs520.

@ti-chi-bot ti-chi-bot bot merged commit af06f7b into tikv:tidb-6.5 Feb 12, 2025
10 checks passed
@cfzjywxk
Copy link
Contributor

@ekexium Need to bump up the client-go dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants