Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: merge map change checker features to the main branch #60

Merged
merged 6 commits into from
Aug 13, 2024

Conversation

anhnv3991
Copy link

Description

  • Merge the all branches related to map change checker to the tier4/main branch

How to test

  • Test together with this PR
  • Need to test with Autoware logging simulator.

@anhnv3991 anhnv3991 changed the title Feature/pcu resolve conflict feat: merge map change checker features to the main branch Aug 8, 2024
@SakodaShintaro
Copy link

For some reason, the CI checks failed. I will investigate.

@SakodaShintaro
Copy link

SakodaShintaro commented Aug 9, 2024

I was able to reproduce the error. Currently, pull requests from forked repositories may fail during CI checks.
#62

@SakodaShintaro
Copy link

SakodaShintaro commented Aug 9, 2024

@anhnv3991
Sorry, could you push the branch to tier4/ndt_omp repository and recreate pull request from the branch?

I might have found a way to fix it. 4fecf84

@SakodaShintaro
Copy link

@anhnv3991
Unfortunately, pre-commit failed.
Could you apply formatter(clang-format) to include/multigrid_pclomp/multigrid_ndt_omp.h?

If you use VSCode, the following extension is useful.

image

@anhnv3991
Copy link
Author

@SakodaShintaro I just used xargs clang-format-14. Which version is used for this pipeline?

@SakodaShintaro
Copy link

SakodaShintaro commented Aug 9, 2024

I use

$ clang-format --version
clang-format version 17.0.5 (https://github.com/ssciwr/clang-format-wheel 1fc815404015575a1c0c40c1994b7522ab89fe86)

But this PR's difference about formatting may come from .clang-format. It is updated in #58, I think this PR's formatting style may be old one.

Copy link

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pclomp/* is not currently used in autoware, so this pull request does not affect its operation. I have confirmed that logging_simulator etc. works properly.
In the future, it may be a good idea to remove these files from this repository and move them to map_assessment_tools.
LGTM

@anhnv3991 anhnv3991 merged commit e32ec1b into tier4:tier4/main Aug 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants