-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Thanksgiving day #2892
Update Thanksgiving day #2892
Conversation
savdagod
commented
Nov 27, 2024
- Display "day" instead of "days" when there is one day left
- Display "Happy Turkey Day!" on Thanksgiving day
Current logic only works for 2024 and 2025. New logic works indefinitely.
Update > 0 day logic to >= 0
Next StepsHello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:
Manual Review RequiredHang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:
|
@jalexcooney Cool to merge this? |
We're automatically closing this issue because it hasn't had any activity in 30 days. If that seems like a mistake, please feel free to re-open. Thanks! |