Update jQuery and jQuery libraries. #63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryoichi-obara
commented
Aug 28, 2017
ryoichi-obara
commented
- jQuery 3.2.1
- jQuery UI 1.12.1
|
Might it be better to add a package.json to track dependencies, instead of including dependencies in this project repo? Then, the package can be published on NPM, with NPM handling installing the dependencies. |
- Add "package.json" - Remove "lib" - Append node_modules/ to ".gitignore"
|
Hello @brylie , thanks for reviewing/pointing. I tried to manage library dependencies with package.json. And should I fix up these commits? |
|
The changes look good, and it is cool to see that this package will be published on NPM :-) Great work! |
Remove useless params.
CommonJS modularize for npm
0.8.9 dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.