Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for devcontainers #11634

Open
wants to merge 6 commits into
base: rpm/develop
Choose a base branch
from

Conversation

adamruzicka
Copy link

@adamruzicka adamruzicka commented Jan 16, 2025

It would be nice if this could get us to a state where those using vscode (or any of the other devcontainer-related tooling) could just open the repo, let the tooling crunch for a bit and then be able to do all the packaging actions without having to fiddle with anything.

TODOs:

  • Add obal, mock and friends. In general get this to a feature parity with what you get when you run the rpm_packaging role from forklift
  • some comments about how to make this work with podman instead of docker

@ekohl
Copy link
Member

ekohl commented Jan 16, 2025

TODOs:

* [ ]  Add obal, mock and friends. In general get this to a feature parity with what you get when you run the [rpm_packaging role](https://github.com/theforeman/forklift/blob/master/roles/rpm_packaging/tasks/main.yml) from forklift

I have https://copr.fedorainfracloud.org/coprs/ekohl/obal/ and think I could publish for EL as well. I used to do that for EL7 but never added EL 8 or 9. Would that make it easier?

Though I see the last tag was over a year ago so we should probably create a new release again.

@adamruzicka
Copy link
Author

We already have the how and the necessary dependencies captured in forklift, but having a copr repo would still make it a little bit easier, although it is not strictly necessary.

@adamruzicka adamruzicka force-pushed the rpm/develop-devcontainer branch from e2cabe5 to 88d9307 Compare January 16, 2025 17:12
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some vague recollection that GH would also recognize these for codespaces and when Vox Pupuli had a credit card attached to it that would bill. Not that we have one now for Foreman, but I still think we should evaluate https://docs.github.com/en/codespaces/managing-codespaces-for-your-organization/choosing-who-owns-and-pays-for-codespaces-in-your-organization just to be sure.


RUN npm install npm2rpm --global

RUN pip3 install packaging requests ruamel-yaml

RUN gem install gem2rpm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprisingly this isn't in EPEL according to https://src.fedoraproject.org/rpms/rubygem-gem2rpm.

RUN pip3 install packaging requests ruamel-yaml
RUN gem install gem2rpm

RUN pip3 install rpmspectool obal
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also surprises me rpmspectool isn't in EPEL (https://src.fedoraproject.org/rpms/rpmspectool). Almost makes me think people typically use Fedora to develop ;)

@adamruzicka adamruzicka force-pushed the rpm/develop-devcontainer branch from f07cd1a to 15810e8 Compare January 17, 2025 09:33
@adamruzicka
Copy link
Author

Alright, this should be more or less ready to go

I have some vague recollection that GH would also recognize these for codespaces

I've heard of that, but have no experience with it and no idea how it works, what the permission model is and who it gets billed to. So yes, definitely something to look into.

@adamruzicka adamruzicka marked this pull request as ready for review January 17, 2025 10:35
@adamruzicka adamruzicka requested a review from a team as a code owner January 17, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants