added route handling and added activestatus using navlink #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit be4c03f): https://tcl-76-smart-shopping-list--pr18-ar-mp-nav-to-all-3un54fzk.web.app (expires Mon, 19 Aug 2024 15:16:26 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 512b1a88be8ae05fd3e727b99332819df760271d |
|
lgtm, I really like the enhanced UI for active and pending status. |
EmmaBin
approved these changes
Aug 13, 2024
| <Outlet /> | ||
| </main> | ||
| <nav className="Nav"> | ||
| <div className="Nav-container"> | ||
| <a href="#" className="Nav-link"> | ||
| <NavLink to="/" style={handleActive}> | ||
| Home |
There was a problem hiding this comment.
Nice implementation of this to handle the active route
mentalcaries
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For an example of how to fill this template out, see this Pull Request.
Description
Marcos and I added functionality to clicking Home, List, and Manage list links in the navbar using NavLink. We added active status feature to enhance UX, so that users can see which page they are actively viewing.
Related Issue
Issue 3: As a user, I want to be able to navigate to all the pages in the application by clicking the links in the nav bar
[#3] (#3
Acceptance Criteria
Type of Changes
enhancementUpdates
Before
After
Testing Steps / QA Criteria