Skip to content

Commit

Permalink
Drop Node <18.20
Browse files Browse the repository at this point in the history
Upgrading to WebdriverIO v9 seems to struggle with lower versions.
  • Loading branch information
textbook committed Dec 27, 2024
1 parent ab2193b commit 95944a3
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:
strategy:
matrix:
node-version:
- "18.0"
- "18.20.0"
- ${{ needs.build.outputs.node-version }}
- "lts/hydrogen"
- "lts/iron"
Expand Down
5 changes: 3 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ flow, as documented [here][4].
environment variable, your `docker-compose.yml` could look something like:

```yaml
version: '3'
---
services:
some_app:
...
Expand Down Expand Up @@ -113,7 +113,8 @@ Note that only the `/authorize` and `/access_token` routes are exposed this way.
The compiled version of `fauxauth`, as released to npm, is tested against the
latest versions of the active Node LTS releases, currently Hydrogen (18), Iron
(20) and Jod (22). Compilation is carried out using TypeScript in the Node
version specified in `.nvmrc`.
version specified in `.nvmrc`. The lowest supported version is documented in
`package.json`'s `engines` field.
### Options
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"private": true,
"description": "Helper application for testing OAuth clients",
"engines": {
"node": ">=18"
"node": ">=18.20"
},
"scripts": {
"build": "npm --workspace packages/fauxauth run build",
Expand Down
2 changes: 1 addition & 1 deletion packages/fauxauth/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"/views"
],
"engines": {
"node": ">=18"
"node": ">=18.20"
},
"scripts": {
"prebuild": "rimraf lib/*",
Expand Down

0 comments on commit 95944a3

Please sign in to comment.