Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for aws_ecr_repository_creation_template #45

Conversation

jakubmatyszewski
Copy link

Description

Add support for aws_ecr_repository_creation_template

Motivation and Context

aws_ecr_repository_creation_template was added in terraform aws provider 5.61.

Breaking Changes

  • no

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@@ -172,6 +172,11 @@ module "ecr_registry" {
}]
}]

# Registry Replication Configuration
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Registry Replication Configuration
# Registry Creation Template

variable "repository_creation_template_lifecycle_policy" {
description = "The lifecycle policy document to apply to any created repositories. See more details about Policy Parameters in the official AWS docs. Consider using the aws_ecr_lifecycle_policy_document data_source to generate/manage the JSON document used for the lifecycle_policy argument."
type = string
default = ""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
default = ""
default = null

variable "repository_creation_template_description" {
description = "The description for this template."
type = string
default = ""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
default = ""
default = null

variable "repository_creation_template_custom_role_arn" {
description = "A custom IAM role to use for repository creation. Required if using repository tags or KMS encryption."
type = string
default = ""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
default = ""
default = null

Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just putting a hold on this since theres quite a bit we'll need to change - most likely this resource will live in its own sub-module

the ECR team has asked me to take a look - will get to this next week

@amontalban
Copy link

Hey @bryantbiggs, just checking in to see if you are working on this feature because we are about to set multiple ECR repositories and will benefit from this. Thanks in advance!

@bryantbiggs
Copy link
Member

working on it this morning as we speak - should know more about rough ETA later today

@bryantbiggs
Copy link
Member

need to revisit tomorrow with fresh eyes but you can take a look here - happy for any early feedback #46

@jakubmatyszewski
Copy link
Author

closing this PR, thanks @bryantbiggs for taking over

@jakubmatyszewski jakubmatyszewski deleted the aws_ecr_repository_creation_template branch September 4, 2024 05:28
@jakubmatyszewski jakubmatyszewski restored the aws_ecr_repository_creation_template branch September 4, 2024 05:28
@jakubmatyszewski jakubmatyszewski deleted the aws_ecr_repository_creation_template branch September 4, 2024 05:28
Copy link

github-actions bot commented Oct 5, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants