Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(scripts/bin/update-packages): cosmetic changes #23195

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

twaik
Copy link
Member

@twaik twaik commented Feb 18, 2025

No description provided.

@twaik twaik requested a review from TomJo2000 February 18, 2025 17:20
@twaik twaik requested a review from Grimler91 as a code owner February 18, 2025 17:20
@TomJo2000
Copy link
Member

I'd prefer to get that merged as part of #22994, that'll save me the headache of untangling the merge conflicts.
But yes we can of course merge those separately, I'd just prefer if it didn't cause additional busywork.
If you're dead set on merging the cleanup first I can spin it out from the other PR and push it to this branch.

@twaik
Copy link
Member Author

twaik commented Feb 18, 2025

I am not dead set on it, but it will be much better. There are even smaller PRs, carrying less changes, that are not being merged (idk why), so if we can merge at least small cleanup changes it will be good.

@TomJo2000
Copy link
Member

I am not dead set on it, but it will be much better. There are even smaller PRs, carrying less changes, that are not being merged (idk why), so if we can merge at least small cleanup changes it will be good.

I fully agree with that sentiment the problem is that that creates significant overhead for me working on #22994 from merge conflicts or needing to rebase the cosmetic changes out into this branch.
And I still have a shitton of refactoring to do on that PR as is.
Damned if I do, damned if I don't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants