addpkg(main/jackett): 0.2.1411 #23166

aicynide · 2025-02-12T10:36:46Z

Closes: #9757

TomJo2000

This looks mostly ready for merge aside from some minor style cleanup.

Has this been tested on-device yet?

packages/jackett/build.sh

truboxl

Besides requesting other changes, please fix your commit authorship. All your recent PRs have the same issue.

From: Your Name <[email protected]>
Date: Wed, 12 Feb 2025 16:04:17 +0530

truboxl · 2025-02-12T21:21:43Z

packages/jackett/build.sh

+TERMUX_PKG_SERVICE_SCRIPT=("jackett" 'exec ${TERMUX_PREFIX}/bin/dotnet ${TERMUX_PREFIX}/lib/jackett/jackett.dll --DataFolder ${TERMUX_ANDROID_HOME}/.config/jackett 2>&1')
+TERMUX_PKG_BLACKLISTED_ARCHES="arm"
+TERMUX_PKG_RM_AFTER_INSTALL="
+lib/jackett/libMono.Unix.so


I am rejecting this. If this lib is published as part of the program, it is essential to the running of the program. Removing it will cause problem. If the check fails, then is should be manually recompiled. EDIT: Retracting since further analysis of source code shows it's not used

erroneously installed mono runtime library should be removed

Technically DllNotFoundException error can still happen when Check For Updates but I see you disabled update so I wont mind
If preferable build the correct libMono.Unix.so manually

truboxl · 2025-02-13T01:15:21Z

$ jackett
The application to execute does not exist: '/data/data/com.termux/files/usr/bin/jackett.dll'.

aicynide · 2025-02-13T13:18:00Z

$ jackett
The application to execute does not exist: '/data/data/com.termux/files/usr/bin/jackett.dll'.

Yeah i tested it, jackett.dll should be copied to $PREFIX/bin

@truboxl run $ dotnet $PREFIX/lib/jackett/jackett.dll

aicynide · 2025-02-16T01:08:28Z

@truboxl fixed everything!
You can run comfortably now
$ jackett
I ask u to set library path before running it

$ export LD_LIBRARY_PATH=/data/data/com.termux/files/usr/lib:$LD_LIBRARY_PATH

Please merge this package now

Co-authored-by: TomIO <[email protected]>

Grimler91

Thanks for the PR!

Grimler91 · 2025-02-16T07:47:41Z

packages/jackett/build.sh

+	cp -r build "${TERMUX_PREFIX}/lib/jackett"
+	cat > $TERMUX_PREFIX/bin/jackett <<HERE
+#!$TERMUX_PREFIX/bin/sh
+export LD_LIBRARY_PATH=$TERMUX_PREFIX/lib:\$LD_LIBRARY_PATH


This should not be necessary. Please set rpath instead, by passing -Wl,-rpath=$TERMUX_PREFIX/lib in some linker flag.

I can't understand, please show full command

I don't know anything about dotnet and what compiler flags it uses, so cannot give a full command. For many systems it is enough to:

export LDFLAGS+=" -Wl,-rpath=$TERMUX_PREFIX/lib"

but maybe dotnet does things differently.

Grimler91 · 2025-02-16T07:49:55Z

packages/jackett/build.sh

+TERMUX_PKG_BUILD_DEPENDS="aspnetcore-targeting-pack-8.0, dotnet-targeting-pack-8.0"
+TERMUX_PKG_DEPENDS="aspnetcore-runtime-8.0, dotnet-host, dotnet-runtime-8.0"
+TERMUX_PKG_BUILD_IN_SRC=true
+TERMUX_PKG_SERVICE_SCRIPT=("jackett" 'exec ${TERMUX_PREFIX}/bin/jackett --DataFolder ${TERMUX_ANDROID_HOME}/.config/jackett 2>&1')


Please replace $TERMUX_PREFIX with just $PREFIX and ${TERMUX_ANDROID_HOME} with $HOME. $TERMUX_PREFIX and $TERMUX_ANDROID_HOME are only available during build, not during runtime on device.

packages/jackett/build.sh

truboxl

If you are not fixing your commit authorship, we are not going to merge this.

truboxl · 2025-02-17T04:53:23Z

packages/jackett/build.sh

+	cp -r build "${TERMUX_PREFIX}/lib/jackett"
+	cat > $TERMUX_PREFIX/bin/jackett <<HERE
+#!$TERMUX_PREFIX/bin/sh
+export LD_LIBRARY_PATH=$TERMUX_PREFIX/lib:\$LD_LIBRARY_PATH


Suggested change

export LD_LIBRARY_PATH=$TERMUX_PREFIX/lib:\$LD_LIBRARY_PATH

truboxl · 2025-02-17T04:55:01Z

packages/jackett/build.sh

+	cat > $TERMUX_PREFIX/bin/jackett <<HERE
+#!$TERMUX_PREFIX/bin/sh
+export LD_LIBRARY_PATH=$TERMUX_PREFIX/lib:\$LD_LIBRARY_PATH
+exec $TERMUX_PREFIX/lib/jackett/jackett --NoUpdates $@


Suggested change

exec $TERMUX_PREFIX/lib/jackett/jackett --NoUpdates $@

exec dotnet $TERMUX_PREFIX/lib/jackett/jackett.dll --NoUpdates "\$@"

truboxl · 2025-02-17T04:56:52Z

packages/jackett/build.sh

+TERMUX_PKG_SERVICE_SCRIPT=("jackett" 'exec ${TERMUX_PREFIX}/bin/dotnet ${TERMUX_PREFIX}/lib/jackett/jackett.dll --DataFolder ${TERMUX_ANDROID_HOME}/.config/jackett 2>&1')
+TERMUX_PKG_BLACKLISTED_ARCHES="arm"
+TERMUX_PKG_RM_AFTER_INSTALL="
+lib/jackett/libMono.Unix.so


Technically DllNotFoundException error can still happen when Check For Updates but I see you disabled update so I wont mind
If preferable build the correct libMono.Unix.so manually

aicynide requested review from Grimler91 and TomJo2000 as code owners February 12, 2025 10:36

aicynide force-pushed the jackett branch 2 times, most recently from 64d9cda to 946ba89 Compare February 12, 2025 12:39

TomJo2000 approved these changes Feb 12, 2025

View reviewed changes

packages/jackett/build.sh Outdated Show resolved Hide resolved

packages/jackett/build.sh Outdated Show resolved Hide resolved

aicynide force-pushed the jackett branch from 0e0a610 to 3c5f31a Compare February 12, 2025 17:14

aicynide requested a review from TomJo2000 February 12, 2025 17:15

aicynide force-pushed the jackett branch 2 times, most recently from 59c84f7 to 84fd348 Compare February 12, 2025 18:14

truboxl requested changes Feb 12, 2025

View reviewed changes

aicynide requested a review from truboxl February 13, 2025 13:18

aicynide force-pushed the jackett branch 3 times, most recently from f5ff830 to 7beff26 Compare February 15, 2025 18:53

aicynide force-pushed the jackett branch 5 times, most recently from c339db1 to f838d05 Compare February 16, 2025 02:26

addpkg(main/jackett): 0.2.1411

9eceef5

Co-authored-by: TomIO <[email protected]>

aicynide force-pushed the jackett branch from f838d05 to 9eceef5 Compare February 16, 2025 02:44

Grimler91 requested changes Feb 16, 2025

View reviewed changes

truboxl requested changes Feb 17, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

addpkg(main/jackett): 0.2.1411 #23166

addpkg(main/jackett): 0.2.1411 #23166

aicynide commented Feb 12, 2025

TomJo2000 left a comment

truboxl left a comment

truboxl Feb 12, 2025 •

edited

Loading

aicynide Feb 13, 2025

truboxl Feb 17, 2025

truboxl commented Feb 13, 2025

aicynide commented Feb 13, 2025

aicynide commented Feb 16, 2025

Grimler91 left a comment

Grimler91 Feb 16, 2025

aicynide Feb 16, 2025

Grimler91 Feb 17, 2025

Grimler91 Feb 16, 2025

aicynide Feb 16, 2025

truboxl left a comment

truboxl Feb 17, 2025

truboxl Feb 17, 2025

truboxl Feb 17, 2025

	exec $TERMUX_PREFIX/lib/jackett/jackett --NoUpdates $@
	exec dotnet $TERMUX_PREFIX/lib/jackett/jackett.dll --NoUpdates "\$@"

addpkg(main/jackett): 0.2.1411 #23166

Are you sure you want to change the base?

addpkg(main/jackett): 0.2.1411 #23166

Conversation

aicynide commented Feb 12, 2025

TomJo2000 left a comment

Choose a reason for hiding this comment

truboxl left a comment

Choose a reason for hiding this comment

truboxl Feb 12, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

truboxl commented Feb 13, 2025

aicynide commented Feb 13, 2025

aicynide commented Feb 16, 2025

Grimler91 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

truboxl left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

truboxl Feb 12, 2025 •

edited

Loading