Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite more traits with futures using async_trait #89

Merged
merged 1 commit into from
Oct 21, 2021
Merged

Conversation

matko
Copy link
Member

@matko matko commented Oct 21, 2021

the LayerStore trait and its implementation have been fully rewritten with async_trait.

Contributes to #56.

@codecov
Copy link

codecov bot commented Oct 21, 2021

Codecov Report

Merging #89 (30a0147) into main (41a3bd4) will decrease coverage by 0.89%.
The diff coverage is 26.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
- Coverage   70.23%   69.33%   -0.90%     
==========================================
  Files          32       32              
  Lines       12219    12302      +83     
  Branches     2359     2431      +72     
==========================================
- Hits         8582     8530      -52     
- Misses       1092     1161      +69     
- Partials     2545     2611      +66     
Impacted Files Coverage Δ
src/storage/layer.rs 65.24% <ø> (-1.50%) ⬇️
src/store/mod.rs 47.83% <17.14%> (-3.17%) ⬇️
src/storage/directory.rs 58.06% <19.23%> (-0.76%) ⬇️
src/storage/cache.rs 48.45% <27.41%> (-7.73%) ⬇️
src/storage/memory.rs 76.51% <41.37%> (-1.11%) ⬇️
src/storage/delta.rs 61.84% <0.00%> (+0.52%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41a3bd4...30a0147. Read the comment docs.

@spl
Copy link
Contributor

spl commented Oct 21, 2021

Related to #56?

Copy link
Contributor

@spl spl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I skimmed through everything. It looks beautiful! ❤️

@matko matko merged commit 4529f1b into main Oct 21, 2021
@matko matko deleted the more_async_trait branch October 21, 2021 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants